fix(nextjs): Use dynamic imports in ClerkProvider - #2292
Merged
LekoArts merged 5 commits intoDec 12, 2023
Conversation
🦋 Changeset detectedLatest commit: d864e20 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
panteliselef
approved these changes
Dec 12, 2023
panteliselef
left a comment
Contributor
There was a problem hiding this comment.
This looks good to me, it's great that u added a docs page as well.
LekoArts
added this pull request to the merge queue
Dec 12, 2023
LekoArts
deleted the
lekoarts/sdk-907-fix-support-for-nextjs-below-v13
branch
December 12, 2023 09:17
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently users of
@clerk/nextjsand Next.js 12 (or older) are seeing an error when booting up their app:From what I can tell the error must have existed since #1840 was merged. But we only recently got a report about this so hopefully not too many people where impacted 🤞
This only needs to be fixed for v4 (as v5 will drop Next.js 12), so that's why the target branch is
release/v4.Docs PR: clerk/clerk-docs#543
Root cause
The
packages/nextjs/src/client-boundary/ClerkProvider.tsxcomponent importsnext/compat/routerand theClerkProviderfor the App router version of Next.js (which usesnext/navigation).Both imports only got introduced in Next.js 13 so that's why they fail on older versions. webpack tries to resolve these imports, then it fails.
Solution
Dynamic imports! Check if
next/compat/routercan be required, if not we're on Next.js 12 or older and we can use the ClerkProvider for Pages.This works on the client-side, but unfortunately not during compilation of the middleware and other parts of Next.js. So we need to tell our users to let webpack ignore these imports as their code paths won't be hit.
Testing
You can test this change yourself by:
next.config.jswithChecklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/clerk-expo@clerk/fastifygatsby-plugin-clerk@clerk/localizations@clerk/nextjs@clerk/clerk-react@clerk/remix@clerk/clerk-sdk-node@clerk/shared@clerk/themes@clerk/typesbuild/tooling/chore